Skip to content

fix: remove py3.6 support and add py3.9 and py3.10 #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix: remove py3.6 support and add py3.9 and py3.10 #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions appveyor-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ image: Ubuntu

environment:
matrix:
- TOXENV: py36
PYTHON_VERSION: '3.6'
- TOXENV: py37
PYTHON_VERSION: '3.7'
- TOXENV: py38
PYTHON_VERSION: '3.8'
- TOXENV: py39
PYTHON_VERSION: '3.9'
- TOXENV: py310
PYTHON_VERSION: '3.10'

build: off

Expand Down
6 changes: 4 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ image: Ubuntu

environment:
matrix:
- TOXENV: py36
PYTHON_VERSION: '3.6'
- TOXENV: py37
PYTHON_VERSION: '3.7'
- TOXENV: py38
PYTHON_VERSION: '3.8'
- TOXENV: py39
PYTHON_VERSION: '3.9'
- TOXENV: py310
PYTHON_VERSION: '3.10'

build: off

Expand Down
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def read_requirements(req="base.txt"):
"NOTICE",
"THIRD_PARTY_LICENSES",
),
python_requires=">=3.7, <=4.0, !=4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we restrict this to only supported versions instead of auto enabling new python versions under 4.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rethinking this. Since this repo is a library, leaving it open like this is likely fine. We may run into problems if we use newer lang features but we have to support the min version anyways.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <=4.0 and !=4.0 instead of just <4.0?

(Or better yet only >=3.7 https://iscinumpy.dev/post/bound-version-constraints/)

install_requires=read_requirements("base.txt"),
include_package_data=True,
extras_require={"dev": read_requirements("dev.txt")},
Expand All @@ -79,9 +80,10 @@ def read_requirements(req="base.txt"):
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Topic :: Internet",
"Topic :: Software Development :: Build Tools",
"Topic :: Utilities",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# and then run "tox" from this directory.

[tox]
envlist = py36, py37, py38
envlist = py37, py38, py39, py310

[testenv]
commands = make pr
Expand Down