Validate swagger method value is a valid dict before processing #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekaiv
approved these changes
Nov 29, 2021
hoffa
approved these changes
Nov 29, 2021
torresxb1
reviewed
Nov 29, 2021
Comment on lines
+548
to
+551
| method_definition, | ||
| 'Value of "{}" ({}) for path {} is not a valid dictionary.'.format( | ||
| method_name, method_definition, path | ||
| ), |
There was a problem hiding this comment.
what's the best way we can avoid having duplicate error messages (like this and the one couple lines above)? To handle this with path items, I created validate_path_item_is_dict, but I'm not sure if there's a better way of handling this (maybe a constant for the string, or a function to get the formatted string, or is it good as is?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.