Skip to content

Conversation

torresxb1
Copy link
Contributor

@torresxb1 torresxb1 commented Nov 24, 2021

Issue #, if available:
aws/aws-sam-cli#3493

Description of changes:

Description of how you validated changes:
Ran transform with debugger and the message was printed properly

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #2245 (352d5e5) into develop (e7a1496) will increase coverage by 0.74%.
The diff coverage is 96.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2245      +/-   ##
===========================================
+ Coverage    93.58%   94.33%   +0.74%     
===========================================
  Files           90       95       +5     
  Lines         6124     6598     +474     
  Branches      1260     1331      +71     
===========================================
+ Hits          5731     6224     +493     
+ Misses         183      179       -4     
+ Partials       210      195      -15     
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø)
samtranslator/region_configuration.py 77.77% <63.63%> (-22.23%) ⬇️
samtranslator/model/api/api_generator.py 93.24% <75.00%> (-1.13%) ⬇️
samtranslator/model/api/http_api_generator.py 91.21% <75.00%> (+0.02%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/intrinsics/actions.py 98.75% <100.00%> (+0.03%) ⬆️
samtranslator/metrics/method_decorator.py 100.00% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0ef76...352d5e5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants