Skip to content

Conversation

mndeveci
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CoshUS and others added 4 commits November 19, 2021 18:18
* feat: add support for event filtering (DDB, Kinesis, SQS) (#90)

* Add support for Event Filtering (DDB, Kinesis, SQS)

* PR feedback

Rename test file.
Move to a variable the list of event types that have event filtering.

* chore: change a test case that CFN doesn't support (#98)

Co-authored-by: Renato Valenzuela <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #2243 (5d3ea53) into develop (e7a1496) will increase coverage by 1.10%.
The diff coverage is 95.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2243      +/-   ##
===========================================
+ Coverage    93.58%   94.68%   +1.10%     
===========================================
  Files           90       95       +5     
  Lines         6124     7041     +917     
  Branches      1260     1530     +270     
===========================================
+ Hits          5731     6667     +936     
+ Misses         183      178       -5     
+ Partials       210      196      -14     
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø)
samtranslator/translator/logical_id_generator.py 100.00% <ø> (+9.09%) ⬆️
samtranslator/region_configuration.py 77.77% <63.63%> (-22.23%) ⬇️
samtranslator/model/api/api_generator.py 93.97% <67.85%> (-0.39%) ⬇️
samtranslator/model/api/http_api_generator.py 91.21% <75.00%> (+0.02%) ⬆️
samtranslator/swagger/swagger.py 96.01% <88.52%> (+2.64%) ⬆️
samtranslator/translator/translator.py 97.26% <90.00%> (+0.07%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b2b72...5d3ea53. Read the comment docs.

@mndeveci mndeveci merged commit 3a0ef76 into develop Nov 23, 2021
@mndeveci mndeveci deleted the hotfix_1_42_release branch November 23, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants