Skip to content

Conversation

JiteshKanojia
Copy link
Contributor

@JiteshKanojia JiteshKanojia commented Oct 4, 2021

*Issue #2135

Description of changes:
Fixed gitpod link redirecting to aws-sam-cli instead of This repository.

Description of how you validated changes:

Checklist:

  • Add/update tests using:
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #2170 (1d5eea8) into develop (e7a1496) will increase coverage by 0.69%.
The diff coverage is 97.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2170      +/-   ##
===========================================
+ Coverage    93.58%   94.27%   +0.69%     
===========================================
  Files           90       95       +5     
  Lines         6124     6428     +304     
  Branches      1260     1290      +30     
===========================================
+ Hits          5731     6060     +329     
+ Misses         183      170      -13     
+ Partials       210      198      -12     
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø)
samtranslator/region_configuration.py 77.77% <63.63%> (-22.23%) ⬇️
samtranslator/translator/translator.py 97.26% <90.00%> (+0.07%) ⬆️
samtranslator/swagger/swagger.py 93.65% <91.89%> (+0.28%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/metrics/method_decorator.py 100.00% <100.00%> (ø)
samtranslator/metrics/metrics.py 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ed6d0...1d5eea8. Read the comment docs.

@JiteshKanojia
Copy link
Contributor Author

@CoshUS hey I am new to open source and have made this little contribution as a part of hacktoberfest, so is to possible to add a hacktoberfest-accepted label to my PR 😄

@hawflau hawflau merged commit 6c5981b into aws:develop Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants