Skip to content

Update AppConfig boto3 client config to shorten timeout #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Update AppConfig boto3 client config to shorten timeout #2070

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a735c
Update AppConfig boto3 client config to shorten timeout
hawflau Jun 24, 2021
61c3723
Update timeout config of AppConfig boto3 client
hawflau Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions samtranslator/feature_toggle/feature_toggle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,9 @@ def __init__(self, application_id, environment_id, configuration_profile_id):
try:
LOG.info("Loading feature toggle config from AppConfig...")
# Lambda function has 120 seconds limit
# (5 + 25) * 2, 60 seconds maximum timeout duration
client_config = Config(connect_timeout=5, read_timeout=25, retries={"total_max_attempts": 2})
# (5 + 5) * 2, 20 seconds maximum timeout duration
# In case of high latency from AppConfig, we can always fall back to use an empty config and continue transform
client_config = Config(connect_timeout=5, read_timeout=5, retries={"total_max_attempts": 2})
self.app_config_client = boto3.client("appconfig", config=client_config)
response = self.app_config_client.get_configuration(
Application=application_id,
Expand Down