fix: Increase PageSize of ListPolicies Paginator #2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAM runs within a Lambda function and loads IAM Managed Policies once per Lambda. Previous to this, SAM would call IAM 9 times which could cause throttling by IAM. With this change, we update the MaxItems from the default of 100 to the max (1000). In local testing, this has shown a 0.6 second reduction in the latency in calling IAM.
Codecov Report
@@ Coverage Diff @@
## develop #2033 +/- ##
===========================================
+ Coverage 93.58% 93.63% +0.05%
===========================================
Files 90 90
Lines 6080 6081 +1
Branches 1247 1247
===========================================
+ Hits 5690 5694 +4
+ Misses 182 180 -2
+ Partials 208 207 -1
Continue to review full report at Codecov.
|
CoshUS
approved these changes
May 18, 2021
hawflau
approved these changes
May 18, 2021
sriram-mv
approved these changes
May 18, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Jun 23, 2021
SAM runs within a Lambda function and loads IAM Managed Policies once per Lambda. Previous to this, SAM would call IAM 9 times which could cause throttling by IAM. With this change, we update the MaxItems from the default of 100 to the max (1000). In local testing, this has shown a 0.6 second reduction in the latency in calling IAM. Co-authored-by: Jacob Fuss <[email protected]>
mgrandis
added a commit
that referenced
this pull request
Jun 23, 2021
* Revert "fix: Crash when using an invalid method in open api (#2001)" (#2021) This reverts commit d57b132. * fix: Increase PageSize of ListPolicies Paginator (#2033) SAM runs within a Lambda function and loads IAM Managed Policies once per Lambda. Previous to this, SAM would call IAM 9 times which could cause throttling by IAM. With this change, we update the MaxItems from the default of 100 to the max (1000). In local testing, this has shown a 0.6 second reduction in the latency in calling IAM. Co-authored-by: Jacob Fuss <[email protected]> * Revert "Issue 1508 remove check requiring identity ... (#1577)" (#2038) This reverts commit 0eb3630. This change caused regression, reverting until the bug is fixed. bug: `ReauthorizeEvery` can be a `dict` when intrinsic functions are used. * chore: bump version to 1.37.0 (#2068) Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: _sam <[email protected]>
mgrandis
added a commit
that referenced
this pull request
Jul 6, 2021
* Release/v1.37.0 (#2069) * chore: bump version to 1.37.0 (#2068) * fix: Increase PageSize of ListPolicies Paginator (#2033) Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> * feat: Support VIRTUAL_HOST as Type for SourceAccessConfiguration for MQ events (#76) (#2078) Co-authored-by: Renato Valenzuela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAM runs within a Lambda function and loads IAM Managed Policies once per
Lambda. Previous to this, SAM would call IAM 9 times which could cause
throttling by IAM. With this change, we update the MaxItems from the
default of 100 to the max (1000). In local testing, this has shown
a 0.6 second reduction in the latency in calling IAM.
Issue #, if available:
n/a
Description of changes:
See above
Description of how you validated changes:
I tested the updated Policy loader in a python interpreter validating the pagination works as expected.
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.