test: Add service exclusion by region #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrandis
suggested changes
Feb 19, 2021
moelasmar
reviewed
Feb 23, 2021
| "basic_function_openapi", | ||
| ] | ||
| ) | ||
| @skipIf(should_exclude_test_in_region("LambdaEnvVars"), "LambdaEnvVars is not supported in this testing region") |
There was a problem hiding this comment.
I could not find the "LambdaEnvVars" in the exclusion file. Does it mean that it should be supported by all regions?
Also, does it mean that all the test cases, should define the functionality name that it got tested by it regardless it will be added to the exclusion file or not?
There was a problem hiding this comment.
I will remove the "LambdaEnvVars" since it we don't use it in the exclusion file. If we don't want to skip a test in certain region, we don't need to define a service/functionality name in the test case within skipIf decorator.
mgrandis
approved these changes
Feb 23, 2021
moelasmar
approved these changes
Feb 24, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add region partition test for foss integration tests
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.