-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Handle Fn::If intrinsic for Alarms #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f, transforms the alarms inside into CFN format and passes it to CFN
elbayaaa
reviewed
Feb 12, 2021
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
elbayaaa
reviewed
Feb 12, 2021
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
elbayaaa
approved these changes
Feb 12, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1923 +/- ##
===========================================
+ Coverage 93.85% 93.94% +0.08%
===========================================
Files 89 89
Lines 5890 5926 +36
Branches 1206 1212 +6
===========================================
+ Hits 5528 5567 +39
+ Misses 166 164 -2
+ Partials 196 195 -1
Continue to review full report at Codecov.
|
hawflau
reviewed
Feb 17, 2021
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
hawflau
approved these changes
Feb 17, 2021
mgrandis
added a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1624
Description of changes:
Handles
Fn::If
inDeploymentPreference/Alarms
where we would only allow a list before.Description of how you validated changes:
Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.