feat(policy-templates): add AcmGetCertificatePolicy #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1853 +/- ##
===========================================
+ Coverage 93.97% 94.02% +0.05%
===========================================
Files 89 89
Lines 5825 5825
Branches 1185 1185
===========================================
+ Hits 5474 5477 +3
+ Misses 162 160 -2
+ Partials 189 188 -1
Continue to review full report at Codecov.
|
mndeveci
approved these changes
Dec 22, 2020
elbayaaa
approved these changes
Feb 12, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
* Policy templates: add AcmGetCertificatePolicy * Add unit tests
|
@forzagreen this is already released as it is mentioned in the linked issue (#1854). Please create a new issue if you are experiencing problems with it. |
|
Thanks @mndeveci. I confirm it was released. However the docs is missing from the policy template list. |
|
Thanks, I will reach out to documentation team about this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1854
Description of changes
Added a policy template
AcmGetCertificatePolicythat give a permission to read a certificate from AWS Certificate Manager.Granted permission: GetCertificate (
acm:GetCertificate)Resource: The certificate ARN.
I pass the full certificate's ARN, not the id, because the CloudFormation resource AWS::CertificateManager::Certificate returns only the ARN.
Usecase
Lambda function in a private network making HTTPS requests to a private server. The Lambda needs to add the certificate chain to its CA Bundle.
Checklist
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.