Skip to content

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Sep 4, 2020

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Steve Brown and others added 19 commits March 20, 2020 13:16
refactor: Remove 2016-10-31 examples
feat: add support for VPCEndpointIds in EndpointConfiguration
Merge 'master' back to 'develop'
…r (v1 and v2). (#1670)

* Adding authorization scopes as list validation in ApiGatewayAuthorizer and ApiGatewayV2Authorizer.

* make black.

* Adding functional test for invalid auth scope.

* adding error condition for invalid test.

* removing test template file.
chore: bump version to 1.26.0
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #1700 into master will decrease coverage by 0.07%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
- Coverage   94.12%   94.05%   -0.08%     
==========================================
  Files          86       86              
  Lines        5547     5463      -84     
  Branches     1167     1100      -67     
==========================================
- Hits         5221     5138      -83     
- Misses        146      148       +2     
+ Partials      180      177       -3     
Impacted Files Coverage Δ
samtranslator/model/cognito.py 85.71% <ø> (+10.71%) ⬆️
samtranslator/model/sam_resources.py 93.37% <ø> (ø)
samtranslator/model/api/api_generator.py 94.91% <87.50%> (-0.28%) ⬇️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/model/apigateway.py 97.12% <100.00%> (+0.02%) ⬆️
samtranslator/model/apigatewayv2.py 94.28% <100.00%> (+0.34%) ⬆️
samtranslator/swagger/swagger.py 92.47% <100.00%> (-0.02%) ⬇️
samtranslator/model/lambda_.py 88.57% <0.00%> (-4.54%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85501ac...6176030. Read the comment docs.

@mndeveci
Copy link
Contributor Author

mndeveci commented Sep 4, 2020

Sycned with @jfuss offline, since this is merged previously, closing it

@mndeveci mndeveci closed this Sep 4, 2020
@jfuss jfuss deleted the release/v1.26.0 branch October 8, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants