Skip to content

Conversation

justinmk3
Copy link
Contributor

@justinmk3 justinmk3 commented Jul 6, 2020

Issue #, if available:
followup to #1290

Description of changes:
Minor fix for missing item in table of contents.

Description of how you validated changes:
Manual validation

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #1649 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1649   +/-   ##
========================================
  Coverage    94.10%   94.10%           
========================================
  Files           86       86           
  Lines         5408     5408           
  Branches      1080     1080           
========================================
  Hits          5089     5089           
  Misses         148      148           
  Partials       171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a20ae...83c8afe. Read the comment docs.

@justinmk3
Copy link
Contributor Author

@mgrandis @awood45 @CoshUS @mingkun2020 is anything blocking this? It's a minor change but is confusing for someone reading the reference. And I don't see where the friction is that has delayed merging it.

@mgrandis
Copy link
Contributor

mgrandis commented Feb 4, 2021

Hey @justinmk3, let me take a look at this

@mgrandis
Copy link
Contributor

mgrandis commented Feb 4, 2021

It seems there was an error with AppVeyor and we are blocked for now.
Could you please try pushing a new commit to see if it unblocks it?
A minor change, like changing the logical id from line 391 to logical ID.

@justinmk3
Copy link
Contributor Author

Rebased

@mgrandis mgrandis merged commit b8dbf3f into aws:develop Feb 4, 2021
@mgrandis
Copy link
Contributor

mgrandis commented Feb 4, 2021

Thanks @justinmk3 !

@justinmk3 justinmk3 deleted the fixtoc branch February 5, 2021 01:30
mgrandis pushed a commit to mgrandis/serverless-application-model that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants