Skip to content

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented May 27, 2020

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv self-requested a review May 27, 2020 15:45
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #1602 into master will increase coverage by 0.03%.
The diff coverage is 94.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   94.06%   94.10%   +0.03%     
==========================================
  Files          78       86       +8     
  Lines        4951     5408     +457     
  Branches     1000     1080      +80     
==========================================
+ Hits         4657     5089     +432     
- Misses        136      148      +12     
- Partials      158      171      +13     
Impacted Files Coverage Δ
samtranslator/public/models.py 0.00% <0.00%> (ø)
samtranslator/translator/verify_logical_id.py 100.00% <ø> (ø)
samtranslator/swagger/swagger.py 92.47% <81.25%> (+0.03%) ⬆️
samtranslator/model/sam_resources.py 93.36% <88.23%> (-0.56%) ⬇️
samtranslator/model/stepfunctions/events.py 88.96% <88.96%> (ø)
samtranslator/model/stepfunctions/generators.py 97.18% <97.18%> (ø)
samtranslator/model/role_utils/role_constructor.py 97.43% <97.43%> (ø)
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/model/iam.py 95.74% <100.00%> (+1.45%) ⬆️
samtranslator/model/resource_policies.py 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3419e...153e06b. Read the comment docs.

@jfuss jfuss merged commit d17bc09 into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants