Skip to content

Issue 1508 remove check requiring identity to be required if ReauthorizeEvery equals zero #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 6, 2021
Merged

Issue 1508 remove check requiring identity to be required if ReauthorizeEvery equals zero #1577

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7204af6
remove check requiring identity to be required
daftster Apr 27, 2020
59dce3a
set identity to empty dictionary
daftster Apr 28, 2020
81deeca
use the correct identity variable
daftster Apr 28, 2020
e2dfd88
Update apigateway.py
daftster Sep 15, 2020
738cf3a
undo change.
daftster Sep 15, 2020
8bee672
remove extra spaces
daftster Sep 15, 2020
6434918
remove some more spaces
daftster Sep 15, 2020
b134e9e
Update test_translator.py
daftster Feb 24, 2021
d5814ba
Merge pull request #1 from aws/develop
daftster Feb 24, 2021
5f50865
make the Lambda Authorizer is optional if the authorization caching i…
moelasmar Mar 25, 2021
1dc698d
add unit testing to cover the InvalidResourceException in case if the…
moelasmar Apr 6, 2021
8b5deb5
black reformat
moelasmar Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions samtranslator/model/apigateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,9 @@ def __init__(
api_logical_id,
name + " Authorizer has invalid " "'FunctionPayloadType': " + function_payload_type + ".",
)

if function_payload_type == "REQUEST" and self._is_missing_identity_source(identity):
raise InvalidResourceException(
api_logical_id,
name + " Authorizer must specify Identity with at least one "
"of Headers, QueryStrings, StageVariables, or Context.",
)

if function_payload_type == "REQUEST" and self._is_missing_identity_source(identity):
identity = {}

self.api_logical_id = api_logical_id
self.name = name
Expand Down