-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add Tags support to Http Api #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests to write:
I may also need to verify that |
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
===========================================
- Coverage 94.36% 94.30% -0.06%
===========================================
Files 78 78
Lines 4685 4709 +24
Branches 937 944 +7
===========================================
+ Hits 4421 4441 +20
- Misses 121 123 +2
- Partials 143 145 +2 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
=========================================
Coverage ? 94.3%
=========================================
Files ? 78
Lines ? 4709
Branches ? 944
=========================================
Hits ? 4441
Misses ? 123
Partials ? 145
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
===========================================
+ Coverage 94.36% 94.39% +0.02%
===========================================
Files 78 78
Lines 4685 4709 +24
Branches 937 944 +7
===========================================
+ Hits 4421 4445 +24
Misses 121 121
Partials 143 143 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
==========================================
Coverage ? 94.39%
==========================================
Files ? 78
Lines ? 4709
Branches ? 944
==========================================
Hits ? 4445
Misses ? 121
Partials ? 143
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
===========================================
- Coverage 94.36% 94.32% -0.04%
===========================================
Files 78 78
Lines 4685 4655 -30
Branches 937 944 +7
===========================================
- Hits 4421 4391 -30
Misses 121 121
Partials 143 143
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
==========================================
Coverage ? 94.39%
==========================================
Files ? 78
Lines ? 4709
Branches ? 944
==========================================
Hits ? 4445
Misses ? 121
Partials ? 143
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Issue #, if available:
N/A
Description of changes:
Add tags support to Serverless::HttpApi resources
Description of how you validated changes:
Deployed templates to CFN to verify tags work, show up in console.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.