Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Feb 20, 2020

Issue #, if available:
N/A
Description of changes:
Add tags support to Serverless::HttpApi resources
Description of how you validated changes:
Deployed templates to CFN to verify tags work, show up in console.
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian changed the title Http tags feat: add Tags support to Http Api Feb 20, 2020
@keetonian
Copy link
Contributor Author

Tests to write:

  • Overwriting tags existing in OpenApi document
  • Test to hit new error case for invalid OpenApi when using Tags

I may also need to verify that tags in the OpenApi document is a list before I assume it is one.

@alexw91
Copy link

alexw91 commented Feb 21, 2020

Codecov Report

Merging #1459 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
- Coverage    94.36%   94.30%   -0.06%     
===========================================
  Files           78       78              
  Lines         4685     4709      +24     
  Branches       937      944       +7     
===========================================
+ Hits          4421     4441      +20     
- Misses         121      123       +2     
- Partials       143      145       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fa3b9...317194b. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@b430500). Click here to learn what that means.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1459   +/-   ##
=========================================
  Coverage           ?   94.3%           
=========================================
  Files              ?      78           
  Lines              ?    4709           
  Branches           ?     944           
=========================================
  Hits               ?    4441           
  Misses             ?     123           
  Partials           ?     145
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.75% <100%> (ø)
samtranslator/model/api/http_api_generator.py 94.95% <50%> (ø)
samtranslator/open_api/open_api.py 93.87% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b430500...317194b. Read the comment docs.

@keetonian keetonian marked this pull request as ready for review February 21, 2020 17:26
@alexw91
Copy link

alexw91 commented Feb 21, 2020

Codecov Report

Merging #1459 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
+ Coverage    94.36%   94.39%   +0.02%     
===========================================
  Files           78       78              
  Lines         4685     4709      +24     
  Branches       937      944       +7     
===========================================
+ Hits          4421     4445      +24     
  Misses         121      121              
  Partials       143      143              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fa3b9...4a6e671. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@b430500). Click here to learn what that means.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1459   +/-   ##
==========================================
  Coverage           ?   94.39%           
==========================================
  Files              ?       78           
  Lines              ?     4709           
  Branches           ?      944           
==========================================
  Hits               ?     4445           
  Misses             ?      121           
  Partials           ?      143
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.75% <100%> (ø)
samtranslator/model/api/http_api_generator.py 98.31% <100%> (ø)
samtranslator/open_api/open_api.py 93.87% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b430500...4a6e671. Read the comment docs.

@alexw91
Copy link

alexw91 commented Feb 21, 2020

Codecov Report

Merging #1459 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
- Coverage    94.36%   94.32%   -0.04%     
===========================================
  Files           78       78              
  Lines         4685     4655      -30     
  Branches       937      944       +7     
===========================================
- Hits          4421     4391      -30     
  Misses         121      121              
  Partials       143      143              
Impacted Files Coverage Δ
samtranslator/plugins/exceptions.py 83.33% <0.00%> (-2.39%) ⬇️
samtranslator/model/iam.py 92.85% <0.00%> (-1.43%) ⬇️
samtranslator/translator/arn_generator.py 86.95% <0.00%> (-0.55%) ⬇️
samtranslator/model/sqs.py 93.33% <0.00%> (-0.42%) ⬇️
samtranslator/validator/validator.py 95.23% <0.00%> (-0.42%) ⬇️
samtranslator/open_api/open_api.py 93.61% <0.00%> (+0.10%) ⬆️
samtranslator/swagger/swagger.py 92.30% <0.00%> (-0.14%) ⬇️
samtranslator/model/__init__.py 98.11% <0.00%> (-0.04%) ⬇️
samtranslator/plugins/globals/globals.py 99.02% <0.00%> (-0.03%) ⬇️
samtranslator/model/sam_resources.py 94.05% <0.00%> (-0.02%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fa3b9...4eeb285. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@b430500). Click here to learn what that means.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1459   +/-   ##
==========================================
  Coverage           ?   94.39%           
==========================================
  Files              ?       78           
  Lines              ?     4709           
  Branches           ?      944           
==========================================
  Hits               ?     4445           
  Misses             ?      121           
  Partials           ?      143
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.75% <100%> (ø)
samtranslator/model/api/http_api_generator.py 98.31% <100%> (ø)
samtranslator/open_api/open_api.py 93.87% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b430500...4eeb285. Read the comment docs.

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keetonian keetonian merged commit a1d7e54 into aws:develop Feb 21, 2020
@keetonian keetonian deleted the http-tags branch February 21, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants