Skip to content

Conversation

timoschilling
Copy link
Contributor

@timoschilling timoschilling commented Feb 7, 2020

Issue #, if available:

The docs says that ProvisionedConcurrentExecutions is a string but https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-version-provisionedconcurrencyconfiguration.html says it's a integer.

Description of changes:

change type kind.

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alexw91
Copy link

alexw91 commented Feb 7, 2020

Codecov Report

Merging #1440 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1440   +/-   ##
========================================
  Coverage    94.37%   94.37%           
========================================
  Files           78       78           
  Lines         4678     4678           
  Branches       934      934           
========================================
  Hits          4415     4415           
  Misses         121      121           
  Partials       142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e0505...b291201. Read the comment docs.

@praneetap praneetap self-assigned this Feb 19, 2020
@jfuss
Copy link
Contributor

jfuss commented Mar 1, 2022

@timoschilling Thank you for the PR however, we are going to remove this file from the repo. Reason is stated here: #2334 but we have docs we maintain with each release and deployed to the AWS Doc site. Instead of keeping the repo and AWS Docs updated, we will keep the AWS Docs updated.

Again thank you for taking the time to submit this.

@jfuss jfuss closed this Mar 1, 2022
@timoschilling timoschilling deleted the patch-1 branch March 1, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants