fix: customstatements in function events #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keetonian
previously approved these changes
Feb 6, 2020
|
Verified that this fixes the issue we found. Issue description: the previous fix (#1395) for resource policies introduced a regression where resource policies added in Function Events were not added to the resulting API. This fixes the regression. |
jlhood
reviewed
Feb 6, 2020
Added support for intrinsics Ref for api auth Added support for fn::if in CustomStatements Fixed the policy getting created for vpc whitelist to be 'OR' instead of 'AND'
praneetap
force-pushed
the
regression-fix
branch
from
e2bd7b3 to
2ff499a
Compare
jlhood
approved these changes
Feb 6, 2020
keetonian
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.