Skip to content

Conversation

dalumiller
Copy link
Contributor

Issue #, if available:
The term "AWS Serverless Application Definition template" is not one I have seen anywhere else in this doc nor on any other doc, but "AWS Serverless Application Model template" is found. I'm assuming this is a prior naming convention that should be updated to prevent confusion.

Description of changes:
Changing two instances of the word "Definition" to "Model"

Description of how you validated changes:
n/a

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Unless I'm mistaken, there's no such thing as an AWS Serverless Application Definition template, and these are supposed to say "Serverless Application Model template".
@codecov-io
Copy link

Codecov Report

Merging #1423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1423   +/-   ##
======================================
  Coverage    94.4%   94.4%           
======================================
  Files          78      78           
  Lines        4556    4556           
  Branches      911     911           
======================================
  Hits         4301    4301           
  Misses        120     120           
  Partials      135     135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de1f6a...ad5be89. Read the comment docs.

@keetonian keetonian changed the base branch from master to develop January 29, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants