-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(policy-templates): add DynamoDBWritePolicy and S3WritePolicy #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would like to have a |
…Policy and s3:DeleteObject from S3WritePolicy
That makes lots of sense. I removed I think a |
Why not the delete policies, it's still short and the style would be the same in the template. |
Codecov Report
@@ Coverage Diff @@
## develop #1374 +/- ##
========================================
Coverage 94.46% 94.46%
========================================
Files 78 78
Lines 4555 4555
Branches 912 912
========================================
Hits 4303 4303
Misses 118 118
Partials 134 134 Continue to review full report at Codecov.
|
@nmoutschen Thank you for your contribution! |
…odel into add-writeonly-policies
Not sure what's going on for the Python2.7 tests. It's failing to import enum, but the enum34 module is installed. This also affects files that are not touched by this PR...
|
Codecov Report
@@ Coverage Diff @@
## develop #1374 +/- ##
===========================================
+ Coverage 94.39% 94.92% +0.52%
===========================================
Files 78 78
Lines 4709 5555 +846
Branches 944 1232 +288
===========================================
+ Hits 4445 5273 +828
- Misses 121 134 +13
- Partials 143 148 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1374 +/- ##
===========================================
+ Coverage 94.39% 94.92% +0.52%
===========================================
Files 78 78
Lines 4709 5555 +846
Branches 944 1232 +288
===========================================
+ Hits 4445 5273 +828
- Misses 121 134 +13
- Partials 143 148 +5
Continue to review full report at Codecov.
|
Issue #, if available:
Description of changes:
Added a policy template DynamoDBWritePolicy that grants write-only access to a DynamoDB table. It grants the following permissions:
Added a policy template S3WritePolicy that grants write-only access to an S3 bucket. It grants the following permissions:
These two policy templates will help in case such as functions triggered by POST or PUT requests from an API Gateway.
Description of how you validated changes:
I ran
make pr
.Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.