Skip to content

Conversation

ShreyaGangishetty
Copy link

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • [] Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #1371 into release/v1.20.0 will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.20.0    #1371      +/-   ##
===================================================
- Coverage             94.4%   94.33%   -0.07%     
===================================================
  Files                   78       78              
  Lines                 4555     4502      -53     
  Branches               911      911              
===================================================
- Hits                  4300     4247      -53     
  Misses                 120      120              
  Partials               135      135
Impacted Files Coverage Δ
samtranslator/translator/translator.py 98.4% <100%> (+0.01%) ⬆️
samtranslator/plugins/exceptions.py 83.33% <0%> (-2.39%) ⬇️
samtranslator/model/iam.py 92.85% <0%> (-1.43%) ⬇️
samtranslator/translator/arn_generator.py 86.95% <0%> (-0.55%) ⬇️
samtranslator/model/sqs.py 93.33% <0%> (-0.42%) ⬇️
samtranslator/validator/validator.py 95.23% <0%> (-0.42%) ⬇️
samtranslator/open_api/open_api.py 93.6% <0%> (-0.29%) ⬇️
samtranslator/swagger/swagger.py 92.77% <0%> (-0.13%) ⬇️
samtranslator/model/__init__.py 98.11% <0%> (-0.04%) ⬇️
samtranslator/plugins/globals/globals.py 99.02% <0%> (-0.03%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d49c7...64fd656. Read the comment docs.

@ShreyaGangishetty ShreyaGangishetty merged commit ca86a73 into aws:release/v1.20.0 Jan 9, 2020
@ShreyaGangishetty ShreyaGangishetty deleted the patch-fix branch March 16, 2020 23:37
@ShreyaGangishetty ShreyaGangishetty restored the patch-fix branch March 16, 2020 23:38
@ShreyaGangishetty ShreyaGangishetty deleted the patch-fix branch March 16, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants