Skip to content

Conversation

smartinspereira
Copy link

Description of changes:

  • just fixed a small typo :)

Description of how you validated changes:

  • you can see the correct property name in the line above

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #1331 into master will decrease coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
- Coverage    95.3%   94.67%   -0.63%     
==========================================
  Files          78       77       -1     
  Lines        5171     4129    -1042     
  Branches     1190      815     -375     
==========================================
- Hits         4928     3909    -1019     
+ Misses        113      108       -5     
+ Partials      130      112      -18
Impacted Files Coverage Δ
samtranslator/swagger/swagger.py 92.57% <0%> (-2.91%) ⬇️
samtranslator/plugins/api/implicit_api_plugin.py 95.57% <0%> (-2.66%) ⬇️
samtranslator/plugins/exceptions.py 83.33% <0%> (-2.39%) ⬇️
samtranslator/model/eventsources/push.py 90.61% <0%> (-1.43%) ⬇️
samtranslator/plugins/globals/globals.py 99.02% <0%> (-0.98%) ⬇️
samtranslator/model/api/api_generator.py 96.72% <0%> (-0.92%) ⬇️
...el/preferences/deployment_preference_collection.py 91.13% <0%> (-0.91%) ⬇️
samtranslator/open_api/open_api.py 93.56% <0%> (-0.83%) ⬇️
samtranslator/model/apigateway.py 97.79% <0%> (-0.66%) ⬇️
samtranslator/translator/arn_generator.py 86.95% <0%> (-0.55%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b6ac0...614aca8. Read the comment docs.

@praneetap praneetap changed the base branch from master to develop December 18, 2019 18:41
Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is fixed in #1233 PR and merged into develop. Could you please pull and rebase the latest changes to see the change fixed?

@ShreyaGangishetty
Copy link

Closing this PR as this was fixed in #1233

@smartinspereira smartinspereira deleted the patch-1 branch January 7, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants