-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore: Adopt black formatting #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1322 +/- ##
========================================
Coverage 94.41% 94.41%
========================================
Files 78 78
Lines 4529 4529
Branches 903 903
========================================
Hits 4276 4276
Misses 119 119
Partials 134 134
Continue to review full report at Codecov.
|
@jfuss I have rebased this PR to to merge into develop. Could you please resolve the merge conflicts? |
@ShreyaGangishetty Rebased with HEAD of develop. On a side note: If the intention is for developers to put code into develop, you should consider moving the default branch to develop instead of master. I expect the default branch to be where code will end up. |
@jfuss Thank you for this suggestion! We had our official SAM documentation in Github until recently. We didn't want to redirect everyone to our develop documentation until the documentation is made official through releases. Now that we have AWS SAM specification it is a good idea to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved the merge conflicts and this PR looks good to me. Thank you for contributing this!!
Issue #, if available:
N/A
Description of changes:
Move this repo from flake8 to black. Previous to this, developers would run
make pr
and handle any pylint or flake8 errors reported manually. With black, which is similar to go's fmt, will automatically format all the files for you. I also added 'pre-commit` configuration, so that way developers can install the git hooks and will ensure all files were formatted with black before doing a push.This will align this repo with AWS SAM CLI's and provide a consistent developer experience for contribution across these repos.
Description of how you validated changes:
Ran
make pr
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.