Skip to content

Conversation

mutablealligator
Copy link

Issue #, if available:

#1163

Description of changes:

Found the link while reading the documentation of SAM

Description of how you validated changes:

Clicked and link and signed myself up for getting a Slack invite.

Checklist:

  • [N/A] Write/update tests
  • [N/A] make pr passes
  • [Y] Update documentation
  • [N/A] Verify transformed template deploys and application functions as expected
  • [N/A] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #1318 into master will decrease coverage by 0.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage    95.3%   94.59%   -0.71%     
==========================================
  Files          78       77       -1     
  Lines        5171     4129    -1042     
  Branches     1190      815     -375     
==========================================
- Hits         4928     3906    -1022     
+ Misses        113      108       -5     
+ Partials      130      115      -15
Impacted Files Coverage Δ
samtranslator/model/iam.py 81.25% <0%> (-4.47%) ⬇️
samtranslator/swagger/swagger.py 92.57% <0%> (-2.91%) ⬇️
samtranslator/plugins/api/implicit_api_plugin.py 95.57% <0%> (-2.66%) ⬇️
samtranslator/plugins/exceptions.py 83.33% <0%> (-2.39%) ⬇️
samtranslator/model/eventsources/push.py 90.61% <0%> (-1.43%) ⬇️
samtranslator/plugins/globals/globals.py 99.02% <0%> (-0.98%) ⬇️
samtranslator/model/api/api_generator.py 96.72% <0%> (-0.92%) ⬇️
...el/preferences/deployment_preference_collection.py 91.13% <0%> (-0.91%) ⬇️
samtranslator/open_api/open_api.py 93.56% <0%> (-0.83%) ⬇️
samtranslator/model/apigateway.py 97.79% <0%> (-0.66%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b6ac0...c7bc43b. Read the comment docs.

@keetonian
Copy link
Contributor

Thanks for bringing this up! I just generated a new link and included it in the PR. The splashthat link was a manual process that we've moved off of in recent months.

@ShreyaGangishetty ShreyaGangishetty changed the base branch from master to develop December 12, 2019 18:15
@ShreyaGangishetty ShreyaGangishetty merged commit 8bbe812 into aws:develop Dec 12, 2019
@mutablealligator mutablealligator deleted the patch-1 branch December 12, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants