Skip to content

Conversation

ShreyaGangishetty
Copy link

Issue #, if available:

Description of changes:

merging master into develop

Description of how you validated changes:
make pr is successful

Checklist:

  • make pr passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment on lines 3339 to 3347
"dev": true
},
"mixin-deep": {
"version": "1.3.1",
"resolved": "https://registry.npmjs.org/mixin-deep/-/mixin-deep-1.3.1.tgz",
"integrity": "sha512-8ZItLHeEgaqEvd5lYBXfm4EZSFCX29Jb9K+lAHhDKzReKBQKj3R+7NOF6tjqYi9t4oI8VUfaWITJQm86wnXGNQ==",
"version": "1.3.2",
"resolved": "https://registry.npmjs.org/mixin-deep/-/mixin-deep-1.3.2.tgz",
"integrity": "sha512-WRoDn//mXBiJ1H40rqa3vH0toePwSsGb45iInWlTySa+Uu4k3tYUSxa2v1KqAiLtvlrSzaExqS1gtk96A9zvEA==",
"dev": true,
"requires": {
"for-in": "^1.0.2",
Copy link
Contributor

@keetonian keetonian Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? It doesn't seem to fit with this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was directly pushed to master #1213. This was the request from bot.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #1266 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1266      +/-   ##
===========================================
+ Coverage    94.48%   94.49%   +<.01%     
===========================================
  Files           72       72              
  Lines         3738     3743       +5     
  Branches       740      740              
===========================================
+ Hits          3532     3537       +5     
  Misses         104      104              
  Partials       102      102
Impacted Files Coverage Δ
samtranslator/model/lambda_.py 88.46% <ø> (ø) ⬆️
samtranslator/model/eventsources/pull.py 94.64% <100%> (+0.52%) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3725f00...76dfb3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants