-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Add an existing SQS queue option to SNS event #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c33f019
refinement: SNS.to_cloudformation
53ningen 6da31a7
refactor: make some parameters injectable to SQSEventSourceMapping an…
53ningen f0f2be5
feat: Add an existing SQS queue option to SNS event
53ningen 90192b6
Add tests
53ningen fd99293
update a document
53ningen 40cba76
throws exception when a QueueARN or QueueURL not given
53ningen 9189a2e
add a unit test for SqsSubscription: false
53ningen 4456c25
Merge branch 'develop' into sns-sqs-lambda
53ningen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| Resources: | ||
| SaveNotificationFunction: | ||
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| CodeUri: s3://sam-demo-bucket/notifications.zip | ||
| Handler: index.save_notification | ||
| Runtime: nodejs8.10 | ||
| Events: | ||
| NotificationTopic: | ||
| Type: SNS | ||
| Properties: | ||
| Topic: !Ref Notifications | ||
| SqsSubscription: | ||
| QueueUrl: !Ref Queue | ||
| QueueArn: !GetAtt Queue.Arn | ||
| QueuePolicyLogicalId: NotificationA | ||
| BatchSize: 8 | ||
| Enabled: true | ||
| FilterPolicy: | ||
| store: | ||
| - example_corp | ||
| price_usd: | ||
| - numeric: | ||
| - ">=" | ||
| - 100 | ||
|
|
||
| Notifications: | ||
| Type: AWS::SNS::Topic | ||
|
|
||
| Queue: | ||
| Type: AWS::SQS::Queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| Resources: | ||
| SaveNotificationFunction: | ||
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| CodeUri: s3://sam-demo-bucket/notifications.zip | ||
| Handler: index.save_notification | ||
| Runtime: nodejs8.10 | ||
| Events: | ||
| NotificationTopic: | ||
| Type: SNS | ||
| Properties: | ||
| Topic: !Ref Notifications | ||
| SqsSubscription: | ||
| QueueUrl: https://sqs.us-east-1.amazonaws.com/123456789012/MyQueue | ||
| QueueArn: arn:aws:sqs:us-east-1:123456789012:MyQueue | ||
| QueuePolicyLogicalId: NotificationB | ||
| BatchSize: 8 | ||
| Enabled: true | ||
| FilterPolicy: | ||
| store: | ||
| - example_corp | ||
| price_usd: | ||
| - numeric: | ||
| - ">=" | ||
| - 100 | ||
|
|
||
| Notifications: | ||
| Type: AWS::SNS::Topic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| { | ||
| "Resources": { | ||
| "Queue": { | ||
| "Type": "AWS::SQS::Queue" | ||
| }, | ||
| "Notifications": { | ||
| "Type": "AWS::SNS::Topic" | ||
| }, | ||
| "NotificationA": { | ||
| "Type": "AWS::SQS::QueuePolicy", | ||
| "Properties": { | ||
| "Queues": [ | ||
| { | ||
| "Ref": "Queue" | ||
| } | ||
| ], | ||
| "PolicyDocument": { | ||
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Action": "sqs:SendMessage", | ||
| "Resource": { | ||
| "Fn::GetAtt": [ | ||
| "Queue", | ||
| "Arn" | ||
| ] | ||
| }, | ||
| "Effect": "Allow", | ||
| "Condition": { | ||
| "ArnEquals": { | ||
| "aws:SourceArn": { | ||
| "Ref": "Notifications" | ||
| } | ||
| } | ||
| }, | ||
| "Principal": "*" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "SaveNotificationFunctionNotificationTopic": { | ||
| "Type": "AWS::SNS::Subscription", | ||
| "Properties": { | ||
| "FilterPolicy": { | ||
| "price_usd": [ | ||
| { | ||
| "numeric": [ | ||
| ">=", | ||
| 100 | ||
| ] | ||
| } | ||
| ], | ||
| "store": [ | ||
| "example_corp" | ||
| ] | ||
| }, | ||
| "Endpoint": { | ||
| "Fn::GetAtt": [ | ||
| "Queue", | ||
| "Arn" | ||
| ] | ||
| }, | ||
| "Protocol": "sqs", | ||
| "TopicArn": { | ||
| "Ref": "Notifications" | ||
| } | ||
| } | ||
| }, | ||
| "SaveNotificationFunctionRole": { | ||
| "Type": "AWS::IAM::Role", | ||
| "Properties": { | ||
| "AssumeRolePolicyDocument": { | ||
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Action": [ | ||
| "sts:AssumeRole" | ||
| ], | ||
| "Effect": "Allow", | ||
| "Principal": { | ||
| "Service": [ | ||
| "lambda.amazonaws.com" | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "ManagedPolicyArns": [ | ||
| "arn:aws-cn:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole", | ||
| "arn:aws-cn:iam::aws:policy/service-role/AWSLambdaSQSQueueExecutionRole" | ||
| ], | ||
| "Tags": [ | ||
| { | ||
| "Value": "SAM", | ||
| "Key": "lambda:createdBy" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "SaveNotificationFunctionNotificationTopicEventSourceMapping": { | ||
| "Type": "AWS::Lambda::EventSourceMapping", | ||
| "Properties": { | ||
| "BatchSize": 8, | ||
| "Enabled": true, | ||
| "FunctionName": { | ||
| "Ref": "SaveNotificationFunction" | ||
| }, | ||
| "EventSourceArn": { | ||
| "Fn::GetAtt": [ | ||
| "Queue", | ||
| "Arn" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "SaveNotificationFunction": { | ||
| "Type": "AWS::Lambda::Function", | ||
| "Properties": { | ||
| "Handler": "index.save_notification", | ||
| "Code": { | ||
| "S3Bucket": "sam-demo-bucket", | ||
| "S3Key": "notifications.zip" | ||
| }, | ||
| "Role": { | ||
| "Fn::GetAtt": [ | ||
| "SaveNotificationFunctionRole", | ||
| "Arn" | ||
| ] | ||
| }, | ||
| "Runtime": "nodejs8.10", | ||
| "Tags": [ | ||
| { | ||
| "Value": "SAM", | ||
| "Key": "lambda:createdBy" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
isinstance(self.SqsSubscription, bool)is True, thenself.SqsSubscriptionis alwaysTrue, because we checked ifself.SqsSubscriptionis False on L388