-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adding delimiter between the hash data components. #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was expecting to see updates to the output files as well. This should change the hash values on the existing tests, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Just waiting for updating test output files, then I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved provided travis passes.
Codecov Report
@@ Coverage Diff @@
## develop #1060 +/- ##
===========================================
+ Coverage 94.92% 94.93% +<.01%
===========================================
Files 69 69
Lines 3253 3255 +2
Branches 633 633
===========================================
+ Hits 3088 3090 +2
Misses 87 87
Partials 78 78
Continue to review full report at Codecov.
|
Issue #, if available:
#191
Description of changes:
Adding a delimiter between the hash components as best practice.
Description of how you validated changes:
make pr
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.