Skip to content

Conversation

praneetap
Copy link
Contributor

@praneetap praneetap commented Aug 1, 2019

Issue #, if available:
#191
Description of changes:
Adding a delimiter between the hash components as best practice.
Description of how you validated changes:
make pr
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was expecting to see updates to the output files as well. This should change the hash values on the existing tests, right?

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just waiting for updating test output files, then I'll approve.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved provided travis passes.

@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #1060 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    94.92%   94.93%   +<.01%     
===========================================
  Files           69       69              
  Lines         3253     3255       +2     
  Branches       633      633              
===========================================
+ Hits          3088     3090       +2     
  Misses          87       87              
  Partials        78       78
Impacted Files Coverage Δ
samtranslator/model/apigateway.py 97.79% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df24a3...6da5e80. Read the comment docs.

@jlhood jlhood merged commit 05eae60 into aws:develop Aug 1, 2019
praneetap added a commit to praneetap/serverless-application-model that referenced this pull request Aug 1, 2019
@praneetap praneetap deleted the delimiter branch August 1, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants