Skip to content

Conversation

53ningen
Copy link
Contributor

Issue #, if available:
none

Description of changes:

  • region and stack-name of api_cognito_auth example was hard corded.
    • when I create stack on us-west-2 region, npm run open-login-page command returns wrong login-page.
    • when I create stack named hoge, npm run configure-cognito-user-pool command fails.
  • I fixed hard corded region and stack-name parameters in package.json

Description of how you validated changes:

After I run the commands below, I verified the example worked well.

  • npm run package-deploy
  • npm run configure-cognito-user-pool

Checklist:

  • [-] Write/update tests
  • [-] make pr passes
  • [-] Update documentation
  • [-] Verify transformed template deploys and application functions as expected
  • [-] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #1049 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1049   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files           69       69           
  Lines         3256     3256           
  Branches       635      635           
========================================
  Hits          3086     3086           
  Misses          88       88           
  Partials        82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f886df...07d55cb. Read the comment docs.

@53ningen 53ningen changed the title fix: hard corded region and stack-name of api_cognito_auth example fix: hard corded region and stack name of api_cognito_auth example Jul 29, 2019
@jlhood jlhood merged commit 8c0c0a0 into aws:develop Jul 30, 2019
@jlhood
Copy link
Contributor

jlhood commented Jul 30, 2019

@53ningen Thanks so much for fixing this!

@53ningen 53ningen deleted the fix/npm-run branch July 30, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants