feature: separating sagemaker dependencies into more use case specific installable components. #1130

nadiaya · 2019-11-20T20:32:08Z

Adding extras_require dependencies subsets for local mode and analytics dependencies.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…c installable components.

sagemaker-bot · 2019-11-20T20:37:21Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T20:48:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2019-11-20T20:45:28Z

setup.py

@@ -38,12 +38,35 @@ def read_version():
    "numpy>=1.9.0",
    "protobuf>=3.1",
    "scipy>=0.19.0",
-    "urllib3>=1.21, <1.25",
    "protobuf3-to-dict>=0.1.5",
    "requests>=2.20.0, <2.21",
    "fabric>=2.0",


I realize this was part of an old change, but fabric should actually be part of test requires

laurenyu · 2019-11-20T20:48:06Z

setup.py

@@ -38,12 +38,35 @@ def read_version():
    "numpy>=1.9.0",
    "protobuf>=3.1",
    "scipy>=0.19.0",
-    "urllib3>=1.21, <1.25",
    "protobuf3-to-dict>=0.1.5",
    "requests>=2.20.0, <2.21",


I realize this isn't strictly in scope, but the request bounds were somewhat defined by docker-compose - we could probably change it to requests>=2.20.0?

change version range for requests dependency #533

narrow requests version bounds #538

Maybe, don't have bandwidth to do a proper check for it as part of this PR knowing how many problems it caused before.

fair enough 😂

laurenyu · 2019-11-20T20:48:55Z

setup.py

    "protobuf3-to-dict>=0.1.5",
    "requests>=2.20.0, <2.21",
    "fabric>=2.0",
 ]

+# Specific use case dependencies
+extras = {"analytics": ["pandas"], "local": ["urllib3>=1.21, <1.25", "docker-compose>=1.23.0"]}


should we add one for tensorflow? (if people want to use the TF serializers/deserializers that require the library itself)

i didn't want to touch it, but actually why not :)

sagemaker-bot · 2019-11-20T20:51:13Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T20:57:54Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T20:58:36Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:00:39Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:00:50Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:03:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:11:37Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:12:05Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:14:07Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:15:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:21:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:21:37Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T21:23:32Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…e next release to make sure we do not break anyone.

sagemaker-bot · 2019-11-20T21:47:18Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T22:01:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T22:07:25Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T22:08:45Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T22:21:40Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-11-20T22:28:34Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nadiaya added 4 commits November 20, 2019 12:04

feature: separating sagemaker dependencies into more use case specifi…

c1f7ff0

…c installable components.

Fix formatting.

35c01aa

Remove "core" from extra dependencies.

617d50f

Fix formatting.

ca5f0d6

Include all extra dependencies in the tests list.

e98d6c8

laurenyu reviewed Nov 20, 2019

View reviewed changes

nadiaya added 3 commits November 20, 2019 12:52

Add warning for urllib3 imports.

349c9d4

Move fabric to test dependencies.

c064a9f

Move tensorflow dependencies into a special extra subset.

978582d

Keep local mode dependencies in the required list to be removed in th…

90d56bf

…e next release to make sure we do not break anyone.

Update documentation.

afc10d1

laurenyu approved these changes Nov 20, 2019

View reviewed changes

nadiaya merged commit 583ec2d into aws:master Nov 21, 2019

nadiaya deleted the dependencies branch November 21, 2019 00:38

nadiaya mentioned this pull request Nov 21, 2019

feature: remove local mode dependencies from the list of required dependencies. #1131

Merged

4 tasks

laurenyu mentioned this pull request May 7, 2020

Remove scipy from required dependencies #1471

Closed

feature: separating sagemaker dependencies into more use case specific installable components. #1130

feature: separating sagemaker dependencies into more use case specific installable components. #1130

Uh oh!

Conversation

nadiaya commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

laurenyu Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

nadiaya Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

laurenyu Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

nadiaya Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

laurenyu Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

laurenyu Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

nadiaya Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 20, 2019

AWS CodeBuild CI Report

Uh oh!

nadiaya commented Nov 20, 2019 •

edited

Loading