Skip to content

Conversation

@ruotingx
Copy link
Contributor

@ruotingx ruotingx commented Oct 6, 2025

Description
Team has decided to use SAGEMAKER_APP_TYPE_LOWERCASE env var to support conversation history on refresh for JupterLab.

Testing Done

  • npm test
  • Build server bundle and tested in a SMUS space

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruotingx ruotingx requested a review from a team as a code owner October 6, 2025 20:58
private isJupyterLabEnvironment(): boolean {
try {
return process.env.JUPYTER_LAB === 'true'
return process.env.SAGEMAKER_APP_TYPE_LOWERCASE === 'jupyterlab'
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: localize jupyterlab somewhere in case of typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.85%. Comparing base (4ce9d8f) to head (1eee974).

Files with missing lines Patch % Lines
...rc/language-server/agenticChat/tabBarController.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   61.87%   61.85%   -0.02%     
==========================================
  Files         261      261              
  Lines       58504    58505       +1     
  Branches     3672     3669       -3     
==========================================
- Hits        36198    36189       -9     
- Misses      22235    22245      +10     
  Partials       71       71              
Flag Coverage Δ
unittests 61.85% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…refresh support

use SAGEMAKER_APP_TYPE_LOWERCASE env var
@ruotingx ruotingx force-pushed the jupyterlab-env-var branch from 6858c7f to ad715ec Compare October 7, 2025 18:18
@Will-ShaoHua Will-ShaoHua merged commit a908195 into aws:main Oct 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants