Skip to content

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Oct 4, 2025

Problem

Currently, both the JSON and YAML generic language servers respond with resolveProvider: true in their initialization response. This signals to clients that these language servers support completion item resolve requests, which these servers don't actually support, resulting in errors when clients send resolve requests.

Solution

This updates resolveProvider to false to accurately describe the capabilities of these language servers.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akoreman akoreman requested a review from a team as a code owner October 4, 2025 19:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.23%. Comparing base (e4a1717) to head (9ccdc66).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ver/aws-lsp-json/src/language-server/jsonServer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   61.24%   61.23%   -0.01%     
==========================================
  Files         261      261              
  Lines       58281    58281              
  Branches     3579     3579              
==========================================
- Hits        35694    35689       -5     
- Misses      22519    22524       +5     
  Partials       68       68              
Flag Coverage Δ
unittests 61.23% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shruti0085 shruti0085 merged commit e11c544 into aws:main Oct 14, 2025
6 checks passed
@akoreman akoreman deleted the yaml-json-init-fix branch October 14, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants