chore(amazonq): add more tests for inline completion codes #2385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atonaamz
commented
Oct 3, 2025
| } | ||
| } | ||
|
|
||
| /** src: https://github.com/aws/aws-toolkit-vscode/blob/3921457b0a2094b831beea0d66cc2cbd2a833890/packages/amazonq/src/app/inline/EditRendering/diffUtils.ts#L18 |
There was a problem hiding this comment.
We are not using these methods anywhere
atonaamz
commented
Oct 3, 2025
| return secondString.slice(0, i) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
These methods are only for NEP but no longer needed: atonaamz@072d13b#diff-7fc86d2d446d18ee020072ff7a970c1314f1f938102b0c0b11bbdb1fba39ae2c
atonaamz
force-pushed
the
unitests2
branch
3 times, most recently
from
e93097c to
334f693
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
+ Coverage 60.84% 61.23% +0.39%
==========================================
Files 261 261
Lines 58437 58281 -156
Branches 3558 3579 +21
==========================================
+ Hits 35556 35689 +133
+ Misses 22814 22524 -290
- Partials 67 68 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atonaamz
changed the title
atonaamz
changed the title
Will-ShaoHua
approved these changes
Oct 6, 2025
bywang56
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
add tests for inline utils files
Solution
add tests for inline utils files and remove unused files
Coverage should go to 85% after this change: https://app.codecov.io/gh/aws/language-servers/commit/b91f1a0de8b711cd1ce24a7389b64daf15e06f72/tree/server/aws-lsp-codewhisperer/src/language-server?dropdown=coverage
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.