Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

Problem

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

leigaol and others added 30 commits August 13, 2025 14:04
* feat(amazonq): read tool ui revamp

* feat(amazonq): read tool message revamp (aws#2049)

* feat(amazonq): read tool message revamp

* fix tests

* feat: file search ui (aws#2078)

* feat: file search ui

* fix tests

* fix integration tests

* remove unnecessary type check

* fix: use quotes instead of backticks

* fix header update issue

* fix integration test
…same name (aws#2118)

* fix(amazonq): handle case where multiple rules are provided with the same name

* fix(amazonq): add unit test for duplicate custom guidelines

* fix(amazonq): add unit test for processToolUses

* fix(amazonq): set context type for AmazonQ.md to rule

* fix(amazonq): add README.md back as rule context type

---------

Co-authored-by: Blake Lazarine <[email protected]>
* fix: proper pathing for additonal context

* fix: update existing tests to also mock path.join()
* fix(amazonq): update process-permission-updates to be the same as previous behavior

* fix(chat-client): update package.json chat-client to prod

* fix(amazonq): retain mcp permissions after disable/enable server

* fix: dont call initOneServer on Built-in

* fix: deny permission does not persist after restart IDE

---------

Co-authored-by: Boyu <[email protected]>
* feat: remove project type validation from LSP layer

* refactor: remove unused validation functions from LSP layer
* fix: fix to add disk caching for mcp admin state

* fix: fix to add logging

* fix: fix to initialize mcpManager in any case and discover servers based on mcpState

* fix: fix for unit test failure
…2140)

* refactor: clean up old NEP code path which is no longer used

* fix: empty userTriggerDecision not being sent for NEP code path

* test: disable telemetry test temporarily

* fix: patch

* revert: a

* revert: a
…tion in JB (aws#2145)

* fix(amazonq): don't let flare send discard for the still valid suggestion in JB

if a valid sessionId is returned back to JB, JB will eventually
send a decision for it, but when user types a character to reject
the current suggestion, on JB side it will 1) send reject for the current
one 2) send a new trigger for the latest context. 2) will happen before
1) which will discard the current active session on flare's end.
We don't want flare to do that for JB.

* fix(amazonq): createSession doesn't need to close the previous session

it should be handled together with telemetry reporting

* fix(amazonq): fix test

* fix(amazonq): test fix attempt

* fix(amazonq): test fix attempt
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: bump agentic version: 1.29.0

* chore: empty commit to start Github Action (aws#2150)

---------

Co-authored-by: aws-toolkit-automation <>
* feat: add basic mcp oauth client

* fix: relax condition for triggering oauth flow; add resilience checks for as availability

* feat: add unit test for auth client

* fix: multiple fixes for remote mcp error and timeout
…ly (aws#2165)

* fix(amazonq): fix for mcp servers operations to edit server specific config

* fix(amazonq): additional mcp server config fixes

* fix: resolve test failures

* fix: update MCP manager configuration
Will-ShaoHua and others added 22 commits August 29, 2025 13:29
* emit errorMessage in addMessage

* fix: emit errorMessage in addMessage
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: enabling model selection for code review tool

* feat: added unit test for model selection for code review tool

* fix: making modelId required for codeReviewTool in input schema validation

* fix: fixing unit tests

---------

Co-authored-by: Laxman Reddy <[email protected]>
* chore: bump agentic version: 1.31.0

* chore: empty commit to trigger release workflow (aws#2203)

---------

Co-authored-by: aws-toolkit-automation <>
)

* fix(amazonq): fix to correct the client for getProfile request

* fix(amazonq): removed unneccessary constructor objects

* fix: fix to add assigned VARs in unit tests
* feat: add supplemental context API

* feat: add supplemental context API support
)

* feat: add custom_transformation folder support to artifact.zip

* feat: add custom transformation folder support with async file operations

* fix: improve custom transformation folder access logging message

---------

Co-authored-by: huawenm <[email protected]>
* feat(amazonq): default to diff-based scans

* feat(amazonq): make /review behavior clearly show it is a diff scan

* fix(amazonq): clean up commented lines

* fix(amazonq): fix maximum finding count in CodeReview tool description

* fix(amazonq): improve messaging for diff vs full scans

* feat(amazonq): have codeReview tool ask for clarification if it is not sure what scope to review

* feat(amazonq): when there is no diff, fall back to a full review

* Update chat-client/src/client/mynahUi.ts

Co-authored-by: Tai Lai <[email protected]>

* fix(amazonq): fix test

* fix(amazonq): fix another test

---------

Co-authored-by: Blake Lazarine <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
* fix: potential xss issue

* fix: addressing comments

* fix: unescaping the history message while opening history tab
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: chungjac <[email protected]>
…rvice (aws#2223)

* Sync feature smus inline suggestions branch from main commits (aws#2109)

* fix(amazonq): leverage lcs to find the chars added and removed (aws#2092)

* fix: update client name to support Sagemaker AI origin for agentic chat (aws#2093)

Co-authored-by: chungjac <[email protected]>

* chore(release): release packages from branch main (aws#2073)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: format version.json after incrementing (aws#2068)

* chore: merge agentic version 1.27.0 (aws#2107)

* Bump agentic version: 1.27.0

* Revert "feat(amazonq): read tool ui revamp"

This reverts commit c65428b.

* fix: the style in version json (aws#2106)

---------

Co-authored-by: aws-toolkit-automation <>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Christopher Christou <[email protected]>

* fix(amazonq): persist mcp configs in agent json on start-up (aws#2112)

---------

Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: chungjac <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christopher Christou <[email protected]>
Co-authored-by: Sherry Lu <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Dung Dong <[email protected]>

* feat(amazonq): Integrate IAM Auth support for InlineSuggestions in Flare (aws#2134)

* Chore: Sync test smus branch with main branch commits (aws#2097)

* fix(amazonq): skips continuous monitoring when WCS sees workspace as idle (aws#2066)

* fix(amazonq): skips continuous monitoring when WCS sees workspace as idle

* fix(amazonq): skips creating remote workspace at the start

---------

Co-authored-by: Jiatong Li <[email protected]>

* fix: sessionManager misused because there are 2 types of manager now (aws#2090)

* chore: mapping adt plugin to abap to let inline suggestion work (aws#2085)

* chore: support inline suggestion in adt plugin for eclipse

* fix: add import URI

* chore: add detailed error description for uri is empty for language id

* feat(amazonq): read tool ui revamp

* feat(amazonq): read tool message revamp (aws#2049)

* feat(amazonq): read tool message revamp

* fix tests

* feat: file search ui (aws#2078)

* feat: file search ui

* fix tests

* fix integration tests

* remove unnecessary type check

* fix: use quotes instead of backticks

* fix: creating a new sesion for Edits trigger with next token (aws#2094)

* chore: bump @aws/mynah-ui to 4.36.4 (aws#2096)

---------

Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Sherry Lu <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: atontb <[email protected]>

* feat(amazonq): add inline suggestion support for iam auth client

* fix(amazonq): skips continuous monitoring when WCS sees workspace as idle (aws#2066)

* fix(amazonq): skips continuous monitoring when WCS sees workspace as idle

* fix(amazonq): skips creating remote workspace at the start

---------

Co-authored-by: Jiatong Li <[email protected]>

* fix: sessionManager misused because there are 2 types of manager now (aws#2090)

* chore: mapping adt plugin to abap to let inline suggestion work (aws#2085)

* fix(amazonq): leverage lcs to find the chars added and removed (aws#2092)

* fix: update client name to support Sagemaker AI origin for agentic chat (aws#2093)

Co-authored-by: chungjac <[email protected]>

* chore(release): release packages from branch main (aws#2073)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: fix test failures in merge due to missing init of IdleWorkspaceManager

---------

Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Sherry Lu <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: atontb <[email protected]>
Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: chungjac <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: invictus <[email protected]>

* fix: add unit tests for IAM flow, remove redundant logs added for testing

* fix: file formatting

* fix: rebase from main, clean up redundant logs

* fix: remove old code refs and debug logs

* feat: use cw proxy server based on iam auth logic check

* fix: todo comment and unused imports

* fix: update codewhisperer server to use proper manager based on iam auth logic check

* feat: create new codewhisperer server instance with dynamic service manager logic and add unit tests

* fix: address pr comments, fix unit tests as per updated service manager logic

---------

Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: chungjac <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christopher Christou <[email protected]>
Co-authored-by: Sherry Lu <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Dung Dong <[email protected]>
Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Jiatong Li <[email protected]>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: atontb <[email protected]>
Co-authored-by: invictus <[email protected]>
Co-authored-by: Laxman Reddy <[email protected]>
* feat: upgrade node version to 24

* fix: adding node 24 to overrides.json and using curl instead wget
@ashishrp-aws ashishrp-aws requested a review from a team as a code owner September 10, 2025 08:23
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 49.11334% with 1320 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.66%. Comparing base (4fe7b20) to head (3b27c7b).

Files with missing lines Patch % Lines
...age-server/agenticChat/tools/mcp/mcpOauthClient.ts 33.05% 324 Missing ⚠️
...nguage-server/agenticChat/agenticChatController.ts 42.08% 194 Missing ⚠️
...rc/language-server/agenticChat/tools/toolServer.ts 0.00% 102 Missing ⚠️
.../language-server/agenticChat/tools/mcp/mcpUtils.ts 53.80% 91 Missing ⚠️
...p-codewhisperer/src/shared/codeWhispererService.ts 35.03% 89 Missing ⚠️
...anguage-server/agenticChat/tools/mcp/mcpManager.ts 66.66% 72 Missing and 3 partials ⚠️
...ge-server/agenticChat/tools/mcp/mcpEventHandler.ts 14.45% 71 Missing ⚠️
...-server/inline-completion/editCompletionHandler.ts 10.60% 59 Missing ⚠️
...-server/workspaceContext/workspaceFolderManager.ts 0.00% 42 Missing ⚠️
...rver/agenticChat/tools/qCodeAnalysis/codeReview.ts 71.71% 28 Missing ⚠️
... and 28 more
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/loop-debug    #2228      +/-   ##
======================================================
- Coverage               59.87%   59.66%   -0.21%     
======================================================
  Files                     253      255       +2     
  Lines                   54971    56437    +1466     
  Branches                 3256     3340      +84     
======================================================
+ Hits                    32912    33672     +760     
- Misses                  21998    22701     +703     
- Partials                   61       64       +3     
Flag Coverage Δ
unittests 59.66% <49.11%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bywang56 bywang56 merged commit 3be59f8 into aws:feature/loop-debug Sep 10, 2025
5 checks passed
@ashishrp-aws ashishrp-aws deleted the feature/loop-debug branch October 9, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.