Skip to content

fix: update client name to support Sagemaker AI origin for agentic chat #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
Merged

fix: update client name to support Sagemaker AI origin for agentic chat #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb4b42
fix: update client name to support Sagemaker AI origin for agentic chat
parameja1 Aug 8, 2025
57c66ae
Merge branch 'aws:main' into smai-q-clientInfo
parameja1 Aug 11, 2025
dc1679a
Merge branch 'main' into smai-q-clientInfo
chungjac Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions server/aws-lsp-codewhisperer/src/shared/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,26 +134,36 @@ describe('getClientName', () => {
})

describe('getOriginFromClientInfo', () => {
it('returns MD_IDE for SMUS-IDE client name', () => {
it('returns MD_IDE for client names starting with SMUS-IDE prefix', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMUS-IDE-1.0.0')
assert.strictEqual(result, 'MD_IDE')
})

it('returns MD_IDE for SMUS-CE client name', () => {
it('returns MD_IDE for client names starting with SMUS-CE prefix', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMUS-CE-1.0.0')
assert.strictEqual(result, 'MD_IDE')
})

it('returns MD_IDE for client names starting with SMUS-IDE prefix', () => {
it('returns MD_IDE for client names starting with SMAI-CE prefix', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMAI-CE-1.0.0')
assert.strictEqual(result, 'MD_IDE')
})

it('returns MD_IDE for SMUS-IDE client name', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMUS-IDE')
assert.strictEqual(result, 'MD_IDE')
})

it('returns MD_IDE for client names starting with SMUS-CE prefix', () => {
it('returns MD_IDE for SMUS-CE client name', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMUS-CE')
assert.strictEqual(result, 'MD_IDE')
})

it('returns MD_IDE for SMAI-CE client name', () => {
const result = getOriginFromClientInfo('AmazonQ-For-SMAI-CE')
assert.strictEqual(result, 'MD_IDE')
})

it('returns IDE for non-SMUS client name', () => {
const result = getOriginFromClientInfo('VSCode-Extension')
assert.strictEqual(result, 'IDE')
Expand Down
7 changes: 6 additions & 1 deletion server/aws-lsp-codewhisperer/src/shared/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,12 @@ export function getClientName(lspParams: InitializeParams | undefined): string |
}

export function getOriginFromClientInfo(clientName: string | undefined): Origin {
if (clientName?.startsWith('AmazonQ-For-SMUS-IDE') || clientName?.startsWith('AmazonQ-For-SMUS-CE')) {
// TODO: Update with a new origin for SMAI case, as a short-term solution Sagemaker AI CE is using same origin as that of Sagemaker Unified Studio's IDE and CE
if (
clientName?.startsWith('AmazonQ-For-SMUS-IDE') ||
clientName?.startsWith('AmazonQ-For-SMUS-CE') ||
clientName?.startsWith('AmazonQ-For-SMAI-CE')
) {
return 'MD_IDE'
}
return 'IDE'
Expand Down
Loading