Skip to content

fix(amazonq): bundle corect registry.node for windows #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

fix(amazonq): bundle corect registry.node for windows #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/aws-lsp-codewhisperer-runtimes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,17 @@ The server is managed via scripts/dev-server.js, which ensures:

**NOTE**: Tests are currently disabled for Windows as we currently face issues with automatically shutting down devserver and cleaning resources after tests are executed.

## Binary Dependencies

### registry.node
The file `_bundle-assets/registry-js/win32-x64/registry.node` is a precompiled binary downloaded from the [registry-js](https://github.com/desktop/registry-js) project.

- **Current version**: v1.16.1 (released May 21, 2024)
- **Source**: https://github.com/desktop/registry-js/releases
- **Purpose**: Provides Windows registry access functionality

**To update**: Download the latest `registry.node` binary for win32-x64 from the registry-js releases page and replace the existing file.

#### Tests configuration
- Test settings are defined in `wdio.conf.ts`
- The actual test implementation is in the `test/e2e` folder
Expand Down
Binary file added app/aws-lsp-codewhisperer-runtimes/_bundle-assets/registry-js/win32-x64/registry.node
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion app/aws-lsp-codewhisperer-runtimes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
"package:prod": "npm run compile && cross-env NODE_OPTIONS=--max_old_space_size=8172 npm run webpack:prod",
"webpack": "webpack",
"webpack:prod": "webpack --config webpack.config.prod.js",
"copy:native-deps:agent-standalone": "copyfiles -f _bundle-assets/registry-js/win32-x64/registry.node build/private/bundle/agent-standalone",
"copy:resources:agent-standalone": "copyfiles -f --error ../../node_modules/@aws/lsp-identity/src/sso/authorizationCodePkce/resources/**/* build/private/bundle/agent-standalone/resources",
"generate:node-assets": "./scripts/download-node.sh && ts-node src/scripts/copy-node-assets.ts",
"generate:build-archive": "./scripts/package.sh",
"ci:generate:agent-standalone": "npm run package:prod && npm run copy:resources:agent-standalone && npm run generate:node-assets && npm run generate:build-archive",
"ci:generate:agent-standalone": "npm run package:prod && npm run copy:native-deps:agent-standalone && npm run copy:resources:agent-standalone && npm run generate:node-assets && npm run generate:build-archive",
"ci:generate:manifest": "ts-node scripts/create-repo-manifest.ts",
"start": "cross-env NODE_OPTIONS=--max_old_space_size=8172 node scripts/dev-server.js start",
"stop-dev-server": "node scripts/dev-server.js stop",
Expand Down
Loading