Skip to content

fix: sometimes Enter does not auto trigger in Java when Java extension is installed #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

fix: sometimes Enter does not auto trigger in Java when Java extension is installed #2005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...-lsp-codewhisperer/src/language-server/inline-completion/auto-trigger/autoTrigger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ describe('Auto Trigger', async () => {
assert.strictEqual(getAutoTriggerType(createContentChange('\n')), 'Enter')
assert.strictEqual(getAutoTriggerType(createContentChange('\r\n')), 'Enter')
assert.strictEqual(getAutoTriggerType(createContentChange('\n ')), 'Enter')
const changes = [{ text: '\n ' }, { text: '' }]
assert.strictEqual(getAutoTriggerType(changes), 'Enter')
})

it('should return undefined for tab changes', () => {
Expand Down
3 changes: 2 additions & 1 deletion ...r/aws-lsp-codewhisperer/src/language-server/inline-completion/auto-trigger/autoTrigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@ function isTabKey(str: string): boolean {
export const getAutoTriggerType = (
contentChanges: TextDocumentContentChangeEvent[]
): CodewhispererAutomatedTriggerType | undefined => {
if (contentChanges.length !== 1) {
if (contentChanges.length < 1 || contentChanges.length > 2) {
// Won't trigger cwspr on multi-line changes
// event.contentChanges.length will be 2 when user press Enter key multiple times
// in certain cases, first contentChange item is valid, 2nd is empty string
return undefined
}
const changedText = contentChanges[0].text
Expand Down
Loading