Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 29, 2025

Problem

In certain cases, when a user hit Enter in certain languages, the documentChangeEvent has a empty string. This is a valid auto trigger. In fact user only input Enter but the IDE decides to add some other documentChangeEvents

Solution

Enable auto trigger for this case.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner July 29, 2025 22:04
@leigaol leigaol changed the title fix: sometimes Enter does not auto trigger in Java when some extension is installed fix: sometimes Enter does not auto trigger in Java when Java extension is installed Jul 29, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.15%. Comparing base (68adf18) to head (2cc561a).

Files with missing lines Patch % Lines
...rver/inline-completion/auto-trigger/autoTrigger.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files         239      239           
  Lines       52115    52116    +1     
  Branches     3127     3129    +2     
=======================================
+ Hits        31869    31874    +5     
+ Misses      20187    20183    -4     
  Partials       59       59           
Flag Coverage Δ
unittests 61.15% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leigaol leigaol merged commit c9af035 into aws:main Jul 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants