Skip to content

Fix IPython config dir retrieval logic #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix IPython config dir retrieval logic #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a437d
Fix IPython config dir retrieval logic
bauer-at-work Aug 29, 2024
93bb680
Update ChangeLog.md
bauer-at-work Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd
- Upgraded Neo4j Bolt driver to v5.x ([Link to PR](https://github.com/aws/graph-notebook/pull/682))
- Added `%get_import_task` line magic ([Link to PR](https://github.com/aws/graph-notebook/pull/668))
- Added `--export-to` JSON file option to `%%graph_notebook_config` ([Link to PR](https://github.com/aws/graph-notebook/pull/684))
- Fix ipython config dir logic ([Link to PR](https://github.com/aws/graph-notebook/pull/687))

## Release 4.5.2 (August 15, 2024)

Expand Down
5 changes: 3 additions & 2 deletions src/graph_notebook/ipython_profile/configure_ipython_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
import os
import json

HOME_PATH = os.path.expanduser("~")
IPYTHON_DIR_TREE = HOME_PATH + '/.ipython/profile_default'
from IPython import paths as ipython_paths

IPYTHON_DIR_TREE = ipython_paths.get_ipython_dir() + "/profile_default"
IPYTHON_CFG_FILE_NAME = 'ipython_config.json'
IPYTHON_CFG_PATH = IPYTHON_DIR_TREE + '/' + IPYTHON_CFG_FILE_NAME

Expand Down
Loading