Skip to content

Fix NoneType serialization for OC query params #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix NoneType serialization for OC query params #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46e253
Fix NoneType serialization for OC query params
michaelnchin Apr 3, 2024
70db310
update changelog
michaelnchin Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd
- Added `--store-format` option to query magics ([Link to PR](https://github.com/aws/graph-notebook/pull/580))
- Added `--export-to` CSV file option to query magics ([Link to PR](https://github.com/aws/graph-notebook/pull/582))
- Fixed unintended formatting in `%%oc explain` widget ([Link to PR](https://github.com/aws/graph-notebook/pull/576))
- Fixed serialization of NoneType for `%%oc` query parameters ([Link to PR](https://github.com/aws/graph-notebook/pull/584))
- Changed `%load` parameter and default value for failOnError ([Link to PR](https://github.com/aws/graph-notebook/pull/577))

## Release 4.1.0 (February 1, 2024)
Expand Down
5 changes: 3 additions & 2 deletions src/graph_notebook/magics/graph_magic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3097,10 +3097,11 @@ def handle_opencypher_query(self, line, cell, local_ns):
else:
query_params_input = args.query_parameters
if isinstance(query_params_input, dict):
query_params = query_params_input
query_params = json.dumps(query_params_input)
else:
try:
query_params = json.loads(query_params_input.replace("'", '"'))
query_params_dict = json.loads(query_params_input.replace("'", '"'))
query_params = json.dumps(query_params_dict)
except Exception as e:
print(f"Invalid query parameter input, ignoring.")

Expand Down