Skip to content

Make Rack Middleware methods public for Rails Abstract implementations #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Make Rack Middleware methods public for Rails Abstract implementations #38

merged 1 commit into from
Oct 29, 2024

Conversation

mullermp
Copy link
Contributor

Long term fix of aws/aws-sdk-rails#76

This makes the find, write, and delete session methods public so that aws-sdk-rails can use a delegator to RackMiddleware after inheriting from ActionDispatch::Session::AbstractStore

alextwoods
alextwoods approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this approach

@mullermp mullermp merged commit cca714c into main Oct 29, 2024
7 checks passed
@mullermp mullermp deleted the public-middleware-methods branch October 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alextwoods alextwoods alextwoods approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods