Skip to content

New MV #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 11, 2020
Merged

New MV #26

merged 9 commits into from
Nov 11, 2020

Conversation

mullermp
Copy link
Contributor

Bumps to V3 of the SDK
Removes Rails (moves functionality to aws-sdk-rails)
Fix some bugs

alextwoods
alextwoods reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - but looks like specs are broken. Credentials aren't getting loaded in the spec_helper. Do these tests rely on aws creds in the env and create an actual ddb table?

@mullermp
Copy link
Contributor Author

Tests pass locally. I do think they are doing "integration" tests using my credentials. I need to take a look at the tests more.

@mullermp mullermp mentioned this pull request Nov 10, 2020
Merged
@mullermp mullermp merged commit cb38b39 into master Nov 11, 2020
@mullermp mullermp deleted the new-mv branch November 11, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alextwoods alextwoods alextwoods left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods