Skip to content

Remove deprecated credential methods from credential providers #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Remove deprecated credential methods from credential providers #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb73a4b
Remove deprecated credential methods from credential providers
mullermp Oct 4, 2019
00bf29b
Merge branch 'master' into remove-credential-key-methods
mullermp Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gems/aws-sdk-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Unreleased Changes
------------------

* Feature - Remove deprecated `access_key_id`, `secret_access_key`, and `session_token` methods in credential providers.

3.74.0 (2019-11-05)
------------------

Expand Down
28 changes: 0 additions & 28 deletions gems/aws-sdk-core/lib/aws-sdk-core/credential_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
require_relative 'deprecations'

module Aws
module CredentialProvider

extend Deprecations

# @return [Credentials]
attr_reader :credentials

Expand All @@ -13,29 +9,5 @@ def set?
!!credentials && credentials.set?
end

# @deprecated This method is subject to errors from a race condition when
# called against refreshable credential objects. This will be removed.
# @see #credentials
def access_key_id
credentials ? credentials.access_key_id : nil
end
deprecated(:access_key_id, use: '#credentials', version: '3.75')

# @deprecated This method is subject to errors from a race condition when
# called against refreshable credential objects. This will be removed.
# @see #credentials
def secret_access_key
credentials ? credentials.secret_access_key : nil
end
deprecated(:secret_access_key, use: '#credentials', version: '3.75')

# @deprecated This method is subject to errors from a race condition when
# called against refreshable credential objects. This will be removed.
# @see #credentials
def session_token
credentials ? credentials.session_token : nil
end
deprecated(:session_token, use: '#credentials', version: '3.75')

end
end
17 changes: 0 additions & 17 deletions gems/aws-sdk-core/spec/aws/assume_role_credentials_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,5 @@ module Aws
c.credentials
end

it 'generates deprecation warnings for credential accessors' do
c = AssumeRoleCredentials.new(
role_arn: 'arn',
role_session_name: 'session')

expect(c).to receive(:warn).exactly(3).times

c.access_key_id
c.secret_access_key
c.session_token

# warnings are not duplicated
c.access_key_id
c.secret_access_key
c.session_token
end

end
end