-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix QuickStart example #1 warnings #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes the following warning when run under -w: aws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39: warning: instance variable @location not initialized
Fixes the following warning when run under -w: aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52: warning: shadowing outer local variable - parts
Fixes the following warning when run under -w: aws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441: warning: shadowing outer local variable - headers
The TravisCI test failure is on JRuby 9.1.5.0 only. My changes pass on all other Rubies. I am not able to reproduce the error on JRuby 9.1.16.0. I wonder if the problem is with JRuby 9.1.5.0 (and has since been fixed in 9.1.16.0)? The error relates to calling [] on a nil object, but the spec says @location should default to nil, which is why I used Robert |
Fixes the following warning when run under -w: aws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39: warning: instance variable @location not initialized
Fixes the following warning when run under -w: aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52: warning: shadowing outer local variable - parts
Fixes the following warning when run under -w: aws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441: warning: shadowing outer local variable - headers
Resolves GitHub issue aws#1696
* Doc updates [ci skip]
I reverted the commit that initialized the location field. I'll work on solving the warning in another way. |
Looks good, thanks! |
Warnings appear when running the sample code under QuickStart Guide to Using the AWS SDK for Ruby with warnings on:
The warnings are:
aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52: warning: shadowing outer local variable - parts
aws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441: warning: shadowing outer local variable - headers
aws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39: warning: instance variable @location not initialized
These updates silence the warnings.