Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 21, 2024

  • changelog is added, npm run add-change

@kuhe
Copy link
Contributor Author

kuhe commented May 22, 2024

testing:

process.env.AWS_SDK_JS_SUPPRESS_MAINTENANCE_MODE_MESSAGE = 1;

const AWS = require("../../lib/aws");

const ec2 = new AWS.EC2({
    region: "us-west-2",
});

const request = ec2.describeFleets({
    Filters: []
});

request.promise();

console.log(request.httpRequest.body);

this logs Action=DescribeFleets&Version=2016-11-15 with the fix, as is intended.

this logs Action=DescribeFleets&Filter=&Version=2016-11-15 without the fix, and the request fails.

@kuhe kuhe marked this pull request as ready for review May 22, 2024 15:24
@kuhe kuhe requested a review from a team as a code owner May 22, 2024 15:24
fn.call(this, name, null);
if (rules.api.protocol !== 'ec2') {
fn.call(this, name, null);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a if (rules.api.protocol === 'ec2') { block below, so there is precedence for exceptional behavior in ec2.

@kuhe kuhe merged commit 8fbfd57 into aws:master May 22, 2024
@kuhe kuhe deleted the fix/ec2 branch May 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants