Olapplin/large object merge #6425
+2,432
−42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "feature", | ||
| "category": "S3", | ||
| "contributor": "", | ||
| "description": "Add support for parallel download for individual part-get for multipart GetObject in s3 async client and Transfer Manager" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.core.internal.async; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
| import java.util.function.Supplier; | ||
| import org.reactivestreams.Subscriber; | ||
| import org.reactivestreams.Subscription; | ||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
| import software.amazon.awssdk.annotations.ThreadSafe; | ||
| import software.amazon.awssdk.utils.Logger; | ||
|
|
||
| /** | ||
| * Subscription which can emit {@link Subscriber#onNext(T)} signals to a subscriber, based on the demand received with the | ||
| * {@link Subscription#request(long)}. It tracks the outstandingDemand that has not yet been fulfilled and used a Supplier | ||
| * passed to it to create the object it needs to emit. | ||
| * @param <T> the type of obejct to emit to the subscriber. | ||
| */ | ||
| @SdkInternalApi | ||
| @ThreadSafe | ||
| public final class EmittingSubscription<T> implements Subscription { | ||
|
|
||
| private Subscriber<? super T> downstreamSubscriber; | ||
| private final AtomicBoolean emitting = new AtomicBoolean(false); | ||
| private final AtomicLong outstandingDemand; | ||
| private final Runnable onCancel; | ||
| private final AtomicBoolean isCancelled; | ||
| private final Supplier<T> supplier; | ||
| private final Logger log; | ||
|
|
||
|
|
||
| private EmittingSubscription(Builder<T> builder) { | ||
| this.downstreamSubscriber = builder.downstreamSubscriber; | ||
| this.outstandingDemand = builder.outstandingDemand; | ||
| this.onCancel = builder.onCancel; | ||
| this.isCancelled = builder.isCancelled; | ||
| this.log = builder.log; | ||
| this.supplier = builder.supplier; | ||
| } | ||
|
|
||
| public static <T> Builder<T> builder() { | ||
| return new Builder<>(); | ||
| } | ||
|
|
||
| @Override | ||
| public void request(long n) { | ||
| if (n <= 0) { | ||
| downstreamSubscriber.onError(new IllegalArgumentException("Amount requested must be positive")); | ||
| return; | ||
| } | ||
| long newDemand = outstandingDemand.updateAndGet(current -> { | ||
| if (Long.MAX_VALUE - current < n) { | ||
| return Long.MAX_VALUE; | ||
| } | ||
| return current + n; | ||
| }); | ||
| log.trace(() -> String.format("new outstanding demand: %s", newDemand)); | ||
| emit(); | ||
| } | ||
|
|
||
| @Override | ||
| public void cancel() { | ||
| isCancelled.set(true); | ||
| downstreamSubscriber = null; | ||
| onCancel.run(); | ||
| } | ||
|
|
||
| private void emit() { | ||
| do { | ||
| if (!emitting.compareAndSet(false, true)) { | ||
| return; | ||
| } | ||
| try { | ||
| if (doEmit()) { | ||
| return; | ||
| } | ||
| } finally { | ||
| emitting.compareAndSet(true, false); | ||
| } | ||
| } while (outstandingDemand.get() > 0); | ||
| } | ||
|
|
||
| private boolean doEmit() { | ||
| long demand = outstandingDemand.get(); | ||
|
|
||
| while (demand > 0) { | ||
| if (isCancelled.get()) { | ||
| return true; | ||
| } | ||
| if (outstandingDemand.get() > 0) { | ||
| demand = outstandingDemand.decrementAndGet(); | ||
| T value; | ||
| try { | ||
| value = supplier.get(); | ||
| } catch (Exception e) { | ||
| downstreamSubscriber.onError(e); | ||
| return true; | ||
| } | ||
| downstreamSubscriber.onNext(value); | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| public static class Builder<T> { | ||
| private Subscriber<? super T> downstreamSubscriber; | ||
| private AtomicLong outstandingDemand = new AtomicLong(0); | ||
|
There was a problem hiding this comment. Is there a reason the builder needs to use Atomics? There was a problem hiding this comment. it is for thread safety, multiple thread might be requesting concurrently |
||
| private AtomicBoolean isCancelled = new AtomicBoolean(false); | ||
| private Logger log = Logger.loggerFor(EmittingSubscription.class); | ||
| private Runnable onCancel; | ||
| private Supplier<T> supplier; | ||
|
|
||
| public Builder<T> downstreamSubscriber(Subscriber<? super T> subscriber) { | ||
| this.downstreamSubscriber = subscriber; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder<T> outstandingDemand(AtomicLong outstandingDemand) { | ||
| this.outstandingDemand = outstandingDemand; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder<T> onCancel(Runnable onCancel) { | ||
| this.onCancel = onCancel; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder<T> isCancelled(AtomicBoolean isCancelled) { | ||
| this.isCancelled = isCancelled; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder<T> log(Logger log) { | ||
| this.log = log; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder<T> supplier(Supplier<T> supplier) { | ||
| this.supplier = supplier; | ||
| return this; | ||
| } | ||
|
|
||
| public EmittingSubscription<T> build() { | ||
| return new EmittingSubscription<>(this); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc wording nit on "as well as" - I think this returns true IFF (if and only if) it supports sending AND receiving non-serially right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so just "and"?