added part count validation for download request

[Fred1155]

Motivation and Context

For the part get request for S3 transfer manager, When a response is received, the S3 Transfer Manager MUST check the value of ContentRange and validate that it matches with the expected range for the specific part number. After all requests have been sent, we should validate that the total number of part GET requests sent matches with the expected PartsCount. This PR implements the validation.

Modifications

Added validation method in MultipartDownloaderSubscriber class

Testing

Added wiremock test for failed test

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[zoewangg]

Is there any way to simulate this error for testing? If not, it's fine.

[Fred1155]

Added unit test using a mock S3 client

[zoewangg]

I believe we should remove validation from here because it's totally valid for publisher to send more data after subscription.

https://github.com/reactive-streams/reactive-streams-jvm

8 If a Subscription is cancelled its Subscriber MUST eventually stop being signaled.
💡 The intent of this rule is to make sure that Publishers respect a Subscriber’s request to cancel a Subscription when Subscription.cancel() has been called. The reason for eventually is because signals can have propagation delay due to being asynchronous.

[L-Applin]

We should probably perform that check when the future is completed, and track the actual amount of time getObject was called here with a new counter instead of relying on currentPart

[L-Applin]

Can we add some tests cases for this new validation?

[L-Applin]

I think we need a test with an actual multipart s3AsyncClient, ie:

S3AsyncClient client = S3AsyncClient client = S3AsyncClient
    .builder()
    .multipartEnabled(true)
    // other configs
    .build();

We can still mock the http client but that might be a hard test to mock, let me think about it to see if there is a way to do it.

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud