Skip to content

Revert "Handle header lists in URLConnection client (#4897)" #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
millems merged 2 commits into from
Feb 23, 2024
Merged

Revert "Handle header lists in URLConnection client (#4897)" #4960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b93c68
Revert "Handle header lists in URLConnection client (#4897)"
millems Feb 22, 2024
5be792c
Merge branch 'master' into millem/fix-url-connection-client-thing
millems Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...ient/src/main/java/software/amazon/awssdk/http/urlconnection/UrlConnectionHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public String clientName() {
private HttpURLConnection createAndConfigureConnection(HttpExecuteRequest request) {
SdkHttpRequest sdkHttpRequest = request.httpRequest();
HttpURLConnection connection = connectionFactory.createConnection(sdkHttpRequest.getUri());
setHeaders(connection, sdkHttpRequest);
sdkHttpRequest.forEachHeader((key, values) -> values.forEach(value -> connection.setRequestProperty(key, value)));

// connection.setRequestProperty("Transfer-Encoding", "chunked") does not work, i.e., property does not get set
if (sdkHttpRequest.matchingHeaders("Transfer-Encoding").contains("chunked")) {
Expand Down Expand Up @@ -180,13 +180,6 @@ private HttpURLConnection createAndConfigureConnection(HttpExecuteRequest reques
return connection;
}

private void setHeaders(HttpURLConnection connection, SdkHttpRequest request) {
request.forEachHeader((name, values) -> {
String commaSeparated = String.join(",", values);
connection.addRequestProperty(name, commaSeparated);
});
}

private HttpURLConnection createDefaultConnection(URI uri, SSLSocketFactory socketFactory) {

Optional<Proxy> proxy = determineProxy(uri);
Expand Down
73 changes: 0 additions & 73 deletions ...ction-client/src/test/java/software/amazon/awssdk/http/urlconnection/HeadersListTest.java
View file
Open in desktop

This file was deleted.