Skip to content

Update requestcompression codegen name #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidh44 merged 2 commits into from
Jan 26, 2024
Merged

Update requestcompression codegen name #4851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae580d
Update codegen to get requestcompression instead of requestCompression
davidh44 Jan 26, 2024
31ab2f3
Update test models
davidh44 Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegen/src/main/java/software/amazon/awssdk/codegen/AddOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public Map<String, OperationModel> constructOperations() {
operationModel.setEndpointTrait(op.getEndpoint());
operationModel.setHttpChecksumRequired(op.isHttpChecksumRequired());
operationModel.setHttpChecksum(op.getHttpChecksum());
operationModel.setRequestCompression(op.getRequestCompression());
operationModel.setRequestcompression(op.getRequestcompression());
operationModel.setStaticContextParams(op.getStaticContextParams());
operationModel.setAuth(getAuthFromOperation(op));

Expand Down
2 changes: 1 addition & 1 deletion codegen/src/main/java/software/amazon/awssdk/codegen/compression/RequestCompression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import software.amazon.awssdk.annotations.SdkInternalApi;

/**
* Class to map the RequestCompression trait of an operation.
* Class to map the requestcompression trait of an operation.
*/
@SdkInternalApi
public class RequestCompression {
Expand Down
10 changes: 5 additions & 5 deletions codegen/src/main/java/software/amazon/awssdk/codegen/model/intermediate/OperationModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public class OperationModel extends DocumentationModel {

private HttpChecksum httpChecksum;

private RequestCompression requestCompression;
private RequestCompression requestcompression;

@JsonIgnore
private Map<String, StaticContextParam> staticContextParams;
Expand Down Expand Up @@ -342,12 +342,12 @@ public void setHttpChecksum(HttpChecksum httpChecksum) {
this.httpChecksum = httpChecksum;
}

public RequestCompression getRequestCompression() {
return requestCompression;
public RequestCompression getRequestcompression() {
return requestcompression;
}

public void setRequestCompression(RequestCompression requestCompression) {
this.requestCompression = requestCompression;
public void setRequestcompression(RequestCompression requestcompression) {
this.requestcompression = requestcompression;
}

public Map<String, StaticContextParam> getStaticContextParams() {
Expand Down
10 changes: 5 additions & 5 deletions codegen/src/main/java/software/amazon/awssdk/codegen/model/service/Operation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class Operation {

private HttpChecksum httpChecksum;

private RequestCompression requestCompression;
private RequestCompression requestcompression;

private Map<String, StaticContextParam> staticContextParams;

Expand Down Expand Up @@ -202,12 +202,12 @@ public void setHttpChecksum(HttpChecksum httpChecksum) {
this.httpChecksum = httpChecksum;
}

public RequestCompression getRequestCompression() {
return requestCompression;
public RequestCompression getRequestcompression() {
return requestcompression;
}

public void setRequestCompression(RequestCompression requestCompression) {
this.requestCompression = requestCompression;
public void setRequestcompression(RequestCompression requestcompression) {
this.requestcompression = requestcompression;
}

public Map<String, StaticContextParam> getStaticContextParams() {
Expand Down
4 changes: 2 additions & 2 deletions .../main/java/software/amazon/awssdk/codegen/poet/client/traits/RequestCompressionTrait.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private RequestCompressionTrait() {
* return an empty code-block.
*/
public static CodeBlock create(OperationModel operationModel, IntermediateModel model) {
if (operationModel.getRequestCompression() == null) {
if (operationModel.getRequestcompression() == null) {
return CodeBlock.of("");
}

Expand All @@ -49,7 +49,7 @@ public static CodeBlock create(OperationModel operationModel, IntermediateModel
throw new IllegalStateException("Request compression for S3 is not yet supported in the AWS SDK for Java.");
}

List<String> encodings = operationModel.getRequestCompression().getEncodings();
List<String> encodings = operationModel.getRequestcompression().getEncodings();

return CodeBlock.of(".putExecutionAttribute($T.REQUEST_COMPRESSION, "
+ "$T.builder().encodings($L).isStreaming($L).build())",
Expand Down
2 changes: 1 addition & 1 deletion ...gen/src/test/resources/software/amazon/awssdk/codegen/poet/client/c2j/json/service-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"method": "POST",
"requestUri": "/"
},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...en/src/test/resources/software/amazon/awssdk/codegen/poet/client/c2j/query/service-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"method": "POST",
"requestUri": "/"
},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/resources/software/amazon/awssdk/codegen/poet/client/c2j/rest-json/service-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"method": "POST",
"requestUri": "/"
},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
}
},
Expand Down
2 changes: 1 addition & 1 deletion codegen/src/test/resources/software/amazon/awssdk/codegen/poet/client/c2j/xml/service-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"method": "POST",
"requestUri": "/"
},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
}
},
Expand Down
4 changes: 2 additions & 2 deletions ...d-classes-test/src/main/resources/codegen-resources/customresponsemetadata/service-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@
},
"input":{"shape":"RequestCompressionStructure"},
"output":{"shape":"RequestCompressionStructure"},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
}
},
Expand All @@ -306,7 +306,7 @@
},
"input":{"shape":"RequestCompressionStructureWithStreaming"},
"output":{"shape":"RequestCompressionStructureWithStreaming"},
"requestCompression": {
"requestcompression": {
"encodings": ["gzip"]
},
"authtype":"v4-unsigned-body"
Expand Down