InputStream#readAllBytes() should receive no premature EOS

[faucct]

A read-call with len == 0 happens here:
https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.base/share/classes/java/io/InputStream.java#L396

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

Thanks @faucct. The change itself looks good; can you please add a test for this here?

aws-sdk-java-v2/utils/src/test/java/software/amazon/awssdk/utils/async/InputStreamSubscriberTest.java

Line 46 in 5aa3ff3

public class InputStreamSubscriberTest {

[faucct]

I have tried adding the test for it, but don’t know, how to skip its compilation on Java 8. @dagnir , could you add it for me, please, if you know the way?

    @EnabledForJreRange(min = JRE.JAVA_9)
    @Test
    public void readAllBytesShouldReceiveNoPrematureEOS() throws IOException {
        publisher.subscribe(subscriber);
        publisher.send(byteBufferOfLength(2 << 14));
        publisher.complete();
        assertThat(subscriber.readAllBytes()).isEqualTo(new byte[2 << 14]);
    }

[dagnir]

Hey sorry for the delayed response. No worries, I can add a test case.

[zoewangg]

Can we add a change log entry for this?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

100.0% Coverage
0.0% Duplication

[dagnir]

@all-contributors please add @faucct for code

[allcontributors]

@dagnir

I've put up a pull request to add @faucct! 🎉