Fix flaky test: SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe #4206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emsThreadSafe Before this change, a producer in the test would not wait for all other producers to finish sending their messages before calling complete(). Because a producer could end up calling complete() before the other publishers finished sending, the test would see those "trailing" messages after the complete() as having been dropped. To fix this, we now wait to call complete() until all producers have finished writing their messages.
dagnir
approved these changes
Jul 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a producer in the test would not wait for all other producers to finish sending their messages before calling complete(). Because a producer could end up calling complete() before the other publishers finished sending, the test would see those "trailing" messages after the complete() as having been dropped. To fix this, we now wait to call complete() until all producers have finished writing their messages.