Skip to content

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Apr 26, 2023

Motivation and Context

Identity resolution is async now. Inside sync client we have to "join", but we can handle the exceptions from async resolution to make it appear like sync.

Modifications

Add a utility joinLikeSync() method to handle exceptions just like the async task would have thrown if it was executed synchronously.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner April 26, 2023 07:24
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 51 Code Smells

55.4% 55.4% Coverage
2.0% 2.0% Duplication

@gosar gosar merged commit fd683d8 into feature/master/sra-identity-auth Apr 26, 2023
@gosar gosar deleted the gosar/sra-ia-identity-joinLikeSync branch April 26, 2023 19:54
aws-sdk-java-automation added a commit that referenced this pull request May 20, 2025
…0faedde75

Pull request: release <- staging/c6349958-553b-4ecd-a769-3410faedde75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants